feat: De-globalize utils, formatters, linker#1278
Merged
mofojed merged 11 commits intodeephaven:mainfrom May 10, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1278 +/- ##
==========================================
+ Coverage 45.43% 45.46% +0.02%
==========================================
Files 502 503 +1
Lines 34764 34799 +35
Branches 8679 8682 +3
==========================================
+ Hits 15794 15820 +26
- Misses 18919 18928 +9
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mofojed
requested changes
May 9, 2023
mofojed
reviewed
May 9, 2023
Member
mofojed
left a comment
There was a problem hiding this comment.
Looks good, just need to update the breaking change list.
Collaborator
Author
|
Updated breaking changes list, fixed wrong |
mofojed
approved these changes
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jsapi-utilspackage. Update all dependent packages.BREAKING CHANGE:
Formatterrequires the JSAPI instance as the first argument.DateTimeColumnFormatter,DecimalColumnFormatter,IntegerColumnFormatter,TableColumnFormatter: static methodisValidand constructor require the JSAPI instance in the first argument.Chartrequires the JSAPI instance passed in the new propdh.WidgetUtils: methodscreateChartModel,createGridModelmethods require the JSAPI instance passed in the first argument.DateTimeOptions,TableInput,useViewportDatahave to be wrapped inApiContext.Providerpassing the JSAPI instance.SettingsUtils: methodsisValidFormatandisFormatRuleValidForSaverequire the JSAPI instance passed in the first argument.SessionUtils: methodscreateConnection,createCoreClientrequire the JSAPI instance passed in the first argument.TableUtilsstatic methodsapplyCustomColumns,applyFilter,applyNeverFilter,applySortconverted to instance methods.DropdownFilterPanel,Linkernow get the JSAPI instance from redux store.DecimalFormatContextMenu.getOptions,IntegerFormatContextMenu.getOptionsnow require the JSAPI instance in the first argument.