fix: Select distinct throwing for tables with multiple columns#1286
Merged
mattrunyon merged 2 commits intodeephaven:mainfrom May 10, 2023
Merged
fix: Select distinct throwing for tables with multiple columns#1286mattrunyon merged 2 commits intodeephaven:mainfrom
mattrunyon merged 2 commits intodeephaven:mainfrom
Conversation
mofojed
approved these changes
May 10, 2023
mattrunyon
added a commit
to mattrunyon/web-client-ui
that referenced
this pull request
May 10, 2023
…aven#1286) Fixes deephaven#1275 The true issue is we modify `IrisGridProxyModel.model` but there's no update propagated to `IrisGrid` because it receives the proxy model which does not actually change. This causes the potential for out of sync model/metrics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1275
The true issue is we modify
IrisGridProxyModel.modelbut there's no update propagated toIrisGridbecause it receives the proxy model which does not actually change. This causes the potential for out of sync model/metrics