fix: notebook panel unsaved indicator not showing after dragging a panel#1325
Merged
fix: notebook panel unsaved indicator not showing after dragging a panel#1325
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1325 +/- ##
==========================================
- Coverage 45.95% 45.94% -0.01%
==========================================
Files 493 493
Lines 34404 34410 +6
Branches 8580 8581 +1
==========================================
Hits 15811 15811
- Misses 18542 18548 +6
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
vbabich
approved these changes
May 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce the issue:
Expected:
Notebook still has unsaved indicator
Actual:
Notebook doesn't have indicator until something causes it to re-render.