feat: Improve golden layout tab overflow drop down behaviour#1330
Merged
feat: Improve golden layout tab overflow drop down behaviour#1330
Conversation
…nto the package, will make it easier to theme later.
- Header no has overflow hidden fixing an issue where the controls causing overflow - Since header has overflow, the dropdown menu is now moved to root while opened - Add logic to flip menu to expand upward when there's no space below - Add long name to test layout to check truncation behaviour - Close menu when item is picked up based on a drag from the dropdown - Resize dropdown when window is resized
Codecov Report
@@ Coverage Diff @@
## main #1330 +/- ##
=======================================
Coverage 45.95% 45.95%
=======================================
Files 494 494
Lines 34423 34423
Branches 8587 8587
=======================================
Hits 15820 15820
Misses 18552 18552
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. |
mofojed
requested changes
Jun 5, 2023
| this.tabDropdownContainer.hide(); | ||
| this.isDropdownShown = false; | ||
|
|
||
| // put it back in the header dom |
Member
There was a problem hiding this comment.
Why are we putting it back in the header DOM? Why don't we just create the container when we show the list and then remove it completely when it's hidden?
Contributor
Author
There was a problem hiding this comment.
I could, but then I would have to re-bind all the listeners, which is not how it works currently.
Contributor
Author
There was a problem hiding this comment.
Which would be easier if this was react and not jquery 🤷
mofojed
approved these changes
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example of incorrect overflow:
