fix: today/yesterday keywords failed on last/first day of month#1336
Merged
mofojed merged 1 commit intodeephaven:mainfrom May 31, 2023
Merged
fix: today/yesterday keywords failed on last/first day of month#1336mofojed merged 1 commit intodeephaven:mainfrom
mofojed merged 1 commit intodeephaven:mainfrom
Conversation
- Wasn't correctly calculating the yesterday/tomorrow dates - Unit tests previously were failing when run on the last day of the month - Mock the system time for consistency in tests - Add tests explicitly testing first and last day of month, year - Fixes deephaven#1335
ethanalvizo
approved these changes
May 31, 2023
Codecov Report
@@ Coverage Diff @@
## main #1336 +/- ##
=======================================
Coverage 45.94% 45.95%
=======================================
Files 493 493
Lines 34410 34414 +4
Branches 8581 8582 +1
=======================================
+ Hits 15811 15814 +3
- Misses 18548 18549 +1
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DateUtils.parseDateRangelogic is incorrect on first and last day of month for yesterday/today #1335