fix: panels menu should only open downwards#1340
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1340 +/- ##
=======================================
Coverage 45.95% 45.95%
=======================================
Files 493 493
Lines 34414 34414
Branches 8582 8582
=======================================
Hits 15814 15814
Misses 18549 18549
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mofojed
approved these changes
Jun 1, 2023
mofojed
requested changes
Jun 1, 2023
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
You marked this feat, should be fix
dsmmcken
changed the title
mofojed
approved these changes
Jun 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed it would shift left sometimes if window is really short. Only allow it to open downwards.