fix: DH-14657 Disconnect handling increase debounce timeout#1347
Merged
mofojed merged 2 commits intodeephaven:mainfrom Jun 2, 2023
Merged
fix: DH-14657 Disconnect handling increase debounce timeout#1347mofojed merged 2 commits intodeephaven:mainfrom
mofojed merged 2 commits intodeephaven:mainfrom
Conversation
mofojed
approved these changes
Jun 2, 2023
Codecov Report
@@ Coverage Diff @@
## main #1347 +/- ##
==========================================
- Coverage 45.95% 45.95% -0.01%
==========================================
Files 493 494 +1
Lines 34414 34422 +8
Branches 8582 8587 +5
==========================================
+ Hits 15814 15817 +3
- Misses 18549 18554 +5
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DH-14657
Increases the timeout to 1s. Immediately shows the disconnect icon on the user settings icon when disconnect happens and changes the tooltip (although it will be extremely difficult for the user to trigger that tooltip since the modal will block access to it 1 second later)
Here's how to test w/ ngrok (I couldn't switch between wired and wireless on my PC b/c I need to fix some wifi drivers apparently)
Then open
localhost:4000in firefox and enable work offline from the File menu