fix: DH-14972 Remove setSearch debounce in CommandHistoryViewportUpdater#1351
Merged
vbabich merged 1 commit intodeephaven:mainfrom Jun 6, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1351 +/- ##
=======================================
Coverage 45.95% 45.95%
=======================================
Files 494 494
Lines 34422 34423 +1
Branches 8587 8587
=======================================
+ Hits 15817 15820 +3
+ Misses 18554 18552 -2
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mofojed
approved these changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an issue with Enterprise command history, where
applyFiltersmethod was called on the history table aftersetViewport, because of thesetSearchdebounce.Fixed by moving the debounce to the parent component.