fix: AuthPluginParent wasn't working when embedded in an iframe#1383
Merged
mofojed merged 2 commits intodeephaven:mainfrom Jun 21, 2023
Merged
fix: AuthPluginParent wasn't working when embedded in an iframe#1383mofojed merged 2 commits intodeephaven:mainfrom
mofojed merged 2 commits intodeephaven:mainfrom
Conversation
- Check for window.opener _or_ window.parent when using AuthPluginParent - Reorder plugin priority to use AuthPluginParent first if specified - Tested using an example html page that both embeds and pops open a new tab
Codecov Report
@@ Coverage Diff @@
## main #1383 +/- ##
==========================================
+ Coverage 45.58% 45.59% +0.01%
==========================================
Files 506 506
Lines 34968 34975 +7
Branches 8735 8737 +2
==========================================
+ Hits 15940 15947 +7
Misses 18977 18977
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
vbabich
previously approved these changes
Jun 21, 2023
- Now it doesn't duplicate the same code
vbabich
approved these changes
Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test:
hello:./gradlew server-jetty-app:run -Ppsk=hellonpm starttin the Web UI at https://localhost:4000:iframe-auth-provider-local.zip
Also tested that going to localhost:4010/?name=t&authProvider=parent directly did not try and use the parent plugin, because it wasn't opened by another window.