fix: legal notices dismisses on click anywhere#1452
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1452 +/- ##
=======================================
Coverage 45.70% 45.70%
=======================================
Files 513 513
Lines 35046 35046
Branches 8781 8781
=======================================
Hits 16017 16017
Misses 18978 18978
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mofojed
approved these changes
Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modal shouldn't be nested inside the button, messes up click handling and makes the modal dismiss on a click anywhere.