fix: Heap usage should tick immediately when dependencies change#1468
Merged
bmingles merged 2 commits intodeephaven:mainfrom Aug 31, 2023
Merged
fix: Heap usage should tick immediately when dependencies change#1468bmingles merged 2 commits intodeephaven:mainfrom
bmingles merged 2 commits intodeephaven:mainfrom
Conversation
0d5afb1 to
b6b4d3d
Compare
Codecov Report
@@ Coverage Diff @@
## main #1468 +/- ##
=======================================
Coverage 45.75% 45.76%
=======================================
Files 515 515
Lines 35073 35078 +5
Branches 8784 8787 +3
=======================================
+ Hits 16048 16053 +5
Misses 18974 18974
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
4bc12eb to
5089176
Compare
5089176 to
37c68f8
Compare
mofojed
approved these changes
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1464 - Heap usage checks now run immediately whenever useEffect dependencies change.