Skip to content

fix: Heap usage should tick immediately when dependencies change#1468

Merged
bmingles merged 2 commits intodeephaven:mainfrom
bmingles:1464-heap-usage-refresh
Aug 31, 2023
Merged

fix: Heap usage should tick immediately when dependencies change#1468
bmingles merged 2 commits intodeephaven:mainfrom
bmingles:1464-heap-usage-refresh

Conversation

@bmingles
Copy link
Copy Markdown
Contributor

@bmingles bmingles commented Aug 28, 2023

fixes #1464 - Heap usage checks now run immediately whenever useEffect dependencies change.

@bmingles bmingles force-pushed the 1464-heap-usage-refresh branch from 0d5afb1 to b6b4d3d Compare August 28, 2023 20:49
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 28, 2023

Codecov Report

Merging #1468 (02c7fb1) into main (6ff27a6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1468   +/-   ##
=======================================
  Coverage   45.75%   45.76%           
=======================================
  Files         515      515           
  Lines       35073    35078    +5     
  Branches     8784     8787    +3     
=======================================
+ Hits        16048    16053    +5     
  Misses      18974    18974           
  Partials       51       51           
Flag Coverage Δ
unit 45.76% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/react-hooks/src/useAsyncInterval.ts 100.00% <100.00%> (ø)

@bmingles bmingles force-pushed the 1464-heap-usage-refresh branch from 4bc12eb to 5089176 Compare August 28, 2023 21:09
@bmingles bmingles force-pushed the 1464-heap-usage-refresh branch from 5089176 to 37c68f8 Compare August 28, 2023 21:15
@bmingles bmingles requested review from mattrunyon and mofojed August 28, 2023 21:26
@bmingles bmingles merged commit 96b27a5 into deephaven:main Aug 31, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 31, 2023
@bmingles bmingles deleted the 1464-heap-usage-refresh branch September 6, 2023 18:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Heap monitor shows 0.0 GB for 10 seconds when page loads

2 participants