fix: Table overflow button has lower priority than grid tokens#1510
Merged
georgecwan merged 1 commit intodeephaven:mainfrom Sep 13, 2023
Merged
fix: Table overflow button has lower priority than grid tokens#1510georgecwan merged 1 commit intodeephaven:mainfrom
georgecwan merged 1 commit intodeephaven:mainfrom
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1510 +/- ##
=======================================
Coverage 46.42% 46.42%
=======================================
Files 558 558
Lines 35691 35691
Branches 8915 8915
=======================================
Hits 16571 16571
Misses 19069 19069
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mofojed
approved these changes
Sep 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mouse handler for the table "view full contents" button was called after the mousehandler for cell tokens. This caused links inside the cell to open if the cell overflow button overlapped with a link inside the cell underneath it.
Priority for GridTokenMouseHandler changed to be after the CellOverflowMouseHandler.
Fixes Table Cell Link is Clickable Through the View Full Contents Icon #1480