refactor: Improve table saver to always use the correct service worker#1515
Merged
mattrunyon merged 3 commits intodeephaven:mainfrom Sep 14, 2023
Merged
refactor: Improve table saver to always use the correct service worker#1515mattrunyon merged 3 commits intodeephaven:mainfrom
mattrunyon merged 3 commits intodeephaven:mainfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1515 +/- ##
==========================================
+ Coverage 45.77% 46.43% +0.65%
==========================================
Files 518 558 +40
Lines 35177 35701 +524
Branches 8813 8912 +99
==========================================
+ Hits 16103 16576 +473
- Misses 19023 19075 +52
+ Partials 51 50 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mofojed
approved these changes
Sep 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #766
BREAKING CHANGE:
TableSavernow expects the service worker to send it a complete URL for download instead of just a file name. DHE will need to adjust itsserviceWorker.jsto incorporate the same changes from this PR.