fix: stuck to bottom on filter clear#1579
Merged
ethanalvizo merged 7 commits intodeephaven:mainfrom Oct 27, 2023
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1579 +/- ##
==========================================
+ Coverage 46.48% 46.74% +0.26%
==========================================
Files 571 583 +12
Lines 36011 36262 +251
Branches 9012 9072 +60
==========================================
+ Hits 16738 16951 +213
- Misses 19221 19259 +38
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mofojed
requested changes
Oct 18, 2023
mofojed
requested changes
Oct 24, 2023
mofojed
requested changes
Oct 25, 2023
mofojed
requested changes
Oct 26, 2023
mofojed
approved these changes
Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1477
Previous comments are in #1571 PR.
Note: Once this PR is merged #1571 can go in as well