fix: Adjusted Monaco "white" colors#1594
Merged
bmingles merged 2 commits intodeephaven:mainfrom Oct 23, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1594 +/- ##
=======================================
Coverage 46.65% 46.65%
=======================================
Files 575 575
Lines 36189 36189
Branches 9063 9063
=======================================
Hits 16883 16883
Misses 19254 19254
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mattrunyon
approved these changes
Oct 23, 2023
Collaborator
mattrunyon
left a comment
mattrunyon
left a comment
There was a problem hiding this comment.
Context for @dsmmcken the colors that can be modified are the blue letters in the highlighted selection (1st item), blue in the non-highlighted, white in highlighted, white in non-highlighted. This sets highlighted and non-highlighted to be the same for both colors
dsmmcken
approved these changes
Oct 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some Monaco suggestion colors
fixes #1592