fix: Log figure errors, don't show infinite spinner

[mofojed]

• Requires Core PR Add support for MultiXYErrorBarSeries, MultiOHLCSeries figures deephaven-core#4763
  • Also need to port that to Enterprise
• Actually look at the errors reported by the figure, and log them so we have a clearer idea of what the issue is when plots are reported as not working
• Also show the error message in the chart panel button bar. Clicking the button will display the full error message.
• Don't show the spinner infinitely if there are no series to load

[codecov]

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (52ba2cd) 46.63% compared to head (438ed4f) 46.60%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1614      +/-   ##
==========================================
- Coverage   46.63%   46.60%   -0.03%     
==========================================
  Files         591      592       +1     
  Lines       36406    36435      +29     
  Branches     9113     9120       +7     
==========================================
+ Hits        16979    16982       +3     
- Misses      19375    19401      +26     
  Partials       52       52              

Flag	Coverage Δ
unit	46.60% <16.66%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
packages/chart/src/ChartTestUtils.ts	96.42% <100.00%> (+0.06%)	⬆️
packages/chart/src/DownsamplingError.ts	0.00% <0.00%> (ø)
packages/chart/src/ChartModel.ts	41.37% <33.33%> (-0.44%)	⬇️
packages/chart/src/FigureChartModel.ts	53.80% <50.00%> (-0.35%)	⬇️
packages/chart/src/Chart.tsx	0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mattrunyon]

Need instructions on how to test this if I'm using the linked core PR

[mofojed]

@mattrunyon updated so you can see the full error message from the UI:

[mofojed]

Use the linked Core PR with Groovy, and test with this snippet:

import static io.deephaven.csv.CsvTools.readCsv
import static io.deephaven.api.agg.Aggregation.AggAvg

cryptoTrades = readCsv("https://media.githubusercontent.com/media/deephaven/examples/main/CryptoCurrencyHistory/CSV/CryptoTrades_20210922.csv")

agg_list = [
    AggLast("Close = Price"),\
    AggFirst("Open = Price"),\
    AggMax("High = Price"),\
    AggMin("Low = Price"),
]

btcBin = cryptoTrades.where(FilterOr.of(Filter.from("Instrument = `BTC/USD`", "Instrument = `ETH/USD`")))
    .update("TimestampBin = lowerBin(Timestamp, HOUR)")
tOHLC = btcBin.aggBy(agg_list, "Instrument", "TimestampBin")

plotByOHLC = ohlcPlotBy("Instrument", tOHLC, "TimestampBin", "Open", "High", "Low", "Close", "Instrument").show()

btcBin2 = cryptoTrades.where("Instrument in `BTC/USD`, `ETH/USD`")
    .update("TimestampBin = lowerBin(Timestamp, HOUR)")
tOHLC2 = btcBin2.aggBy(agg_list, "Instrument", "TimestampBin")

plotByOHLC2 = ohlcPlotBy("Instrument", tOHLC2, "TimestampBin", "Open", "High", "Low", "Close", "Instrument").show()

I then commented out the changes in FigureWidgetTranslator part from that linked PR so that same snippet produces a plot with an error, and the error appears correctly.