fix: Date argument non-optional for the onChange prop#1622
Merged
mofojed merged 4 commits intodeephaven:mainfrom Nov 10, 2023
Merged
fix: Date argument non-optional for the onChange prop#1622mofojed merged 4 commits intodeephaven:mainfrom
mofojed merged 4 commits intodeephaven:mainfrom
Conversation
Signed-off-by: sakibian <sakib192@gmail.com>
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
sakibian
changed the title
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
sakibian
changed the title
mofojed
requested changes
Nov 3, 2023
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Just remove the unnecessary comments. Thank you for the contribution!
Signed-off-by: sakibian <sakib192@gmail.com>
mofojed
previously approved these changes
Nov 3, 2023
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
Signed-off-by: sakibian <sakib192@gmail.com>
auto-merge was automatically disabled
November 4, 2023 12:20
Head branch was pushed to by a user without write access
mofojed
requested changes
Nov 6, 2023
- Only need the param on the callback to be required, the onChange prop itself is optional
mofojed
approved these changes
Nov 10, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1622 +/- ##
==========================================
- Coverage 46.68% 46.64% -0.04%
==========================================
Files 583 591 +8
Lines 36267 36402 +135
Branches 9074 9113 +39
==========================================
+ Hits 16930 16979 +49
- Misses 19285 19371 +86
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1601