fix: remove unecessary dom re-calc in grid render#1632
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1632 +/- ##
==========================================
- Coverage 46.71% 46.70% -0.02%
==========================================
Files 583 589 +6
Lines 36308 36359 +51
Branches 9094 9103 +9
==========================================
+ Hits 16961 16980 +19
- Misses 19295 19327 +32
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mofojed
approved these changes
Nov 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at some perf snapshots I noticed calls to updateCanvasScale on every grid render had a ~0.25-0.5ms perf cost (including table ticks). Mostly due to touching the dom with the set width/set height calls triggering a recalculate style call and the getScale call. While insignificant, it is also unnecessary unless size actually changes. Making it conditional improves perf on most re-renders. I used parseFloat in case grid somehow ends up with fractional pixel if set outside of our control (which shouldn't happen, but you never know with plugins).
Before:

After:

updateCanvasScale is now gone from the perf profile entirely on a normal grid render.
Tested re-sizeing panels, and window with table both shown and hidden still resizes grid correctly.