feat: "Group" column for rollup/tree tables#1636
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1636 +/- ##
==========================================
- Coverage 46.74% 46.65% -0.10%
==========================================
Files 606 606
Lines 36762 36852 +90
Branches 9227 9255 +28
==========================================
+ Hits 17184 17192 +8
- Misses 19526 19608 +82
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dcab5d1 to
559d4d6
Compare
mattrunyon
left a comment
There was a problem hiding this comment.
The organize columns menu shows the group column name (although that may need to be unique right now and can be fixed separately)
I tried to add an aggregate column and it crashed my table
Linker can connect to/from the group column. Doesn't crash the table, but does create an invalid textbox if it's the receiving side of a link
93cf84d to
afc495a
Compare
afc495a to
e3667e5
Compare
|
Still an issue that you can link into/out of the virtual column. At least for the link into, it creates an invalid filter on the column which is unclearable unless you use the clear all filters keyboard shortcut (ctrl+e). Linking out works, but feels odd since it's the key column and can have multiple types. I'd say just don't make it a linkable column at all |
mattrunyon
left a comment
There was a problem hiding this comment.
Just need to fix the linker issue
… cell - Proxies to getting the menu items from the actual cell
- It was duplicating the constituent data, which was not what we wanted
- Can clear column filter from line up - Should actually clear _all_ group filters and have a different name...
- Returns the range of columns that should be cleared when clearing the filter on this column
- "Key column" is more descriptive
- Add support for `DisplayColumn` with a `displayName` prop - Clean up some comments
- Just some minor cleanup
- Now it doesn't crash when you add aggregations
- Don't show the proxy column in the Organize Columns, Search Columns, or aggregations sections - Fix an issue with rehydrating tree tables with an aggregation set (table.size can be negative on initial load)
- It just gets weird
f137935 to
8187250
Compare


Uh oh!
There was an error while loading. Please reload this page.