feat: Theme Selector#1661
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1661 +/- ##
==========================================
- Coverage 46.65% 46.63% -0.02%
==========================================
Files 599 602 +3
Lines 36671 36718 +47
Branches 9192 9204 +12
==========================================
+ Hits 17109 17124 +15
- Misses 19510 19542 +32
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
left a comment
There was a problem hiding this comment.
Some minor cleanup, looks good overall
| const themePluginEntries = [...pluginMap.entries()].filter( | ||
| (entry): entry is [string, ThemePlugin] => isThemePlugin(entry[1]) | ||
| ); |
There was a problem hiding this comment.
I think you can shorten it, you're not using the keys at all:
| const themePluginEntries = [...pluginMap.entries()].filter( | |
| (entry): entry is [string, ThemePlugin] => isThemePlugin(entry[1]) | |
| ); | |
| const themePluginEntries = [...pluginMap.values()].filter(isThemePlugin); |
There was a problem hiding this comment.
The keys aren't used here, but they do get consumed in the next block when themePluginEntries is iterated, so the key + value needs to be present
a097d86 to
9f4f3aa
Compare
resolves #1660