fix: add right margin to <Button kind='inline'/> using icons#1664
Merged
fix: add right margin to <Button kind='inline'/> using icons#1664
Conversation
btn-inline did not have a rule to add margin to svgs in the css, like other kinds. This should do it in a backwards compitable way, and ensure all button kinds have the correct margin. We have a bunch of css for other kinds that would be no longer necessary, but not removing in case we use it in a non-standard way elsewhere. ```jsx // previously missing margin between icon and text <button kind="inline" icon="dhTruck">Test</Button> ```
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1664 +/- ##
==========================================
+ Coverage 46.62% 46.64% +0.02%
==========================================
Files 597 599 +2
Lines 36620 36681 +61
Branches 9172 9196 +24
==========================================
+ Hits 17073 17109 +36
- Misses 19495 19520 +25
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mattrunyon
requested changes
Dec 4, 2023
Collaborator
mattrunyon
left a comment
mattrunyon
left a comment
There was a problem hiding this comment.
Looks good. Just wanted to add a little more context to the comment for future us
Co-authored-by: Matthew Runyon <matthewrunyon@deephaven.io>
mattrunyon
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
btn-inline did not have a rule to add margin to svgs in the css, like other kinds. This should do it in a backwards compatible way, and ensure all button kinds have the correct margin. We have a bunch of css for other kinds that would be no longer necessary, but not removing in case we use it in a non-standard way elsewhere.
edit: was somewhat more complicated then expected, because children doesn't mean visible children