fix: figure_title and chart_title were not mapped up correctly#1676
fix: figure_title and chart_title were not mapped up correctly#1676mofojed merged 4 commits intodeephaven:mainfrom
figure_title and chart_title were not mapped up correctly#1676Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1676 +/- ##
==========================================
+ Coverage 46.65% 46.67% +0.02%
==========================================
Files 606 606
Lines 36852 36873 +21
Branches 9255 9267 +12
==========================================
+ Hits 17192 17211 +19
- Misses 19608 19610 +2
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I think we need to still support this behaviour as that's what our docs said to use, so people have been using chart_title like it was figure_title. Maybe only in the case where figure_title is null or chart_title count == 1 or something. |
- We currently were showing the first charts title as the figure title
- Needed to add annotations for it - Fixes deephaven#1675
- Fallback to chart title if there is only one chart and the figure title is not set - Use `yshift` property to position the text correctly regardless of size of plot
c5a47a0 to
9ee6592
Compare
mattrunyon
left a comment
There was a problem hiding this comment.
Looks good. Just want to confirm w/ @dsmmcken that the chart title spacing is good (it's consistent now regardless of panel size)
|
Spacing is fine |

annotationsto get it to work correctlyFigure().figure_title()does not render a title in the IDE or in Jupyter #1674 , Fixeschart_titledoesn't title subplots #1675