fix: Unable to delete selected rows in some input tables#1678
Merged
mofojed merged 1 commit intodeephaven:mainfrom Dec 8, 2023
Merged
fix: Unable to delete selected rows in some input tables#1678mofojed merged 1 commit intodeephaven:mainfrom
mofojed merged 1 commit intodeephaven:mainfrom
Conversation
- Erroneously assumed that the key columns were the first columns in the table - Removed unused delete function from `IrisGridTableModelTemplate` - It should only be implemented for regular JsTables as JsTreeTables do not have input tables - Was duplicated code - Fixes deephaven#1677 - Tested using the code in the ticket
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1678 +/- ##
==========================================
+ Coverage 46.63% 46.68% +0.05%
==========================================
Files 604 604
Lines 36753 36711 -42
Branches 9211 9206 -5
==========================================
Hits 17139 17139
+ Misses 19562 19520 -42
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vbabich
approved these changes
Dec 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IrisGridTableModelTemplate