feat: Action button tooltips#1706
Merged
bmingles merged 2 commits intodeephaven:mainfrom Jan 4, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1706 +/- ##
==========================================
- Coverage 46.68% 46.67% -0.01%
==========================================
Files 609 609
Lines 36985 36991 +6
Branches 9306 9312 +6
==========================================
Hits 17265 17265
- Misses 19668 19674 +6
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
requested changes
Jan 3, 2024
| @@ -1,15 +1,18 @@ | |||
| /* eslint-disable camelcase */ | |||
Member
There was a problem hiding this comment.
Unnecessary. In cases where we do need to go against eslint rules, should opt for disabling a single line only wherever possible.
Suggested change
| /* eslint-disable camelcase */ |
mofojed
approved these changes
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tooltip prop to action button components
resolves #1705