feat: Default Plotly map colors#1721
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1721 +/- ##
==========================================
- Coverage 46.48% 46.48% -0.01%
==========================================
Files 617 617
Lines 37288 37292 +4
Branches 9376 9379 +3
==========================================
+ Hits 17335 17336 +1
- Misses 19899 19902 +3
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a7a9a21 to
6658266
Compare
|
@dsmmcken Should we remove the frame? We can control |
| geo: { | ||
| showcoastlines: true, |
There was a problem hiding this comment.
Need to add geo.bgcolor. I'd say just set it to plot_bgcolor instead of making a separate variable for it
|
I changed the bgcolor to The frame is drawn around the map or the entire visible area if it extends past the visible map. So maybe we want a slightly different bgcolor to match the panel background and no frame |
|
In your example, I would expect the area inside the red line to have the slightly lighter bg color, and everything outside to have the content-bg color. Then hiding the frame is fine. |
|
I set |



Testing
Here's a Python snippet that can be used to see the map colors