feat: Improved preload variable handling#1723
Merged
bmingles merged 4 commits intodeephaven:mainfrom Jan 11, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1723 +/- ##
=======================================
Coverage 46.44% 46.45%
=======================================
Files 611 611
Lines 37204 37209 +5
Branches 9363 9364 +1
=======================================
+ Hits 17279 17284 +5
Misses 19871 19871
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
previously approved these changes
Jan 11, 2024
Comment on lines
+47
to
+50
| function noop(): void { | ||
| // no-op | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
You can use the EMPTY_FUNCTION constant instead from @deephaven/utils.
Contributor
Author
There was a problem hiding this comment.
ah, I went ahead and updated
mofojed
approved these changes
Jan 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1695 and part of #1679