fix: hcm caret shouldn't be allowed to shrink#1733
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1733 +/- ##
=======================================
Coverage 46.48% 46.48%
=======================================
Files 617 617
Lines 37289 37289
Branches 9378 9378
=======================================
Hits 17335 17335
Misses 19900 19900
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
Is there any way to see this in the UI? |
Contributor
Author
|
yeah, styleguide under "popper", there's one there. |
bmingles
approved these changes
Jan 18, 2024
Contributor
bmingles
left a comment
bmingles
left a comment
There was a problem hiding this comment.
I confirmed this works even when removing the hack one here in DHE:
https://github.com/deephaven-ent/iris/pull/1274/commits/95109dc081d2c08ca9688fe2de56e67b1fd49e29#diff-68b9bf7ddb27c0286469a4bb26223b15844511f56dbe2a37f7f5724d02e8505cR25-R27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caret shouldn't shrink if component is truncating. Component only used in enterprise right now, and there's a duplicate change in deephaven-ent/iris#1274