Skip to content

fix: sorting frozen columns#1749

Merged
mofojed merged 5 commits intodeephaven:mainfrom
wusteven815:fix-frozen-sort
Feb 7, 2024
Merged

fix: sorting frozen columns#1749
mofojed merged 5 commits intodeephaven:mainfrom
wusteven815:fix-frozen-sort

Conversation

@wusteven815
Copy link
Copy Markdown
Contributor

@wusteven815 wusteven815 commented Jan 25, 2024

@wusteven815 wusteven815 self-assigned this Jan 25, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 25, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (47f53dc) 46.03% compared to head (d600d04) 46.12%.
Report is 20 commits behind head on main.

Files Patch % Lines
...ity-ordering-builder/VisibilityOrderingBuilder.tsx 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1749      +/-   ##
==========================================
+ Coverage   46.03%   46.12%   +0.09%     
==========================================
  Files         621      627       +6     
  Lines       37455    37633     +178     
  Branches     9413     9474      +61     
==========================================
+ Hits        17244    17360     +116     
- Misses      20157    20218      +61     
- Partials       54       55       +1     
Flag Coverage Δ
unit 46.12% <90.90%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wusteven815 wusteven815 requested a review from mofojed January 25, 2024 20:56
@wusteven815 wusteven815 marked this pull request as ready for review January 25, 2024 20:56
Copy link
Copy Markdown
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to confirm with @dsmmcken - do we want the frozen columns to be sorted as well when you click sort? My instinct is no, we want the frozen columns to stay in the same order they were frozen in.

@dsmmcken
Copy link
Copy Markdown
Contributor

Yeah, I would not sort the frozen columns

@wusteven815 wusteven815 requested a review from mofojed January 26, 2024 17:10
@wusteven815 wusteven815 marked this pull request as draft January 29, 2024 16:35
@wusteven815 wusteven815 marked this pull request as ready for review February 2, 2024 18:45
@wusteven815 wusteven815 requested a review from mofojed February 5, 2024 17:27
@mofojed mofojed merged commit 51e60c5 into deephaven:main Feb 7, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 7, 2024
@wusteven815 wusteven815 deleted the fix-frozen-sort branch February 9, 2024 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Freezing a column then sorting columns in the organize column results in wrong column frozen

3 participants