fix: sorting frozen columns#1749
Merged
mofojed merged 5 commits intodeephaven:mainfrom Feb 7, 2024
wusteven815:fix-frozen-sort
Merged
fix: sorting frozen columns#1749mofojed merged 5 commits intodeephaven:mainfrom wusteven815:fix-frozen-sort
mofojed merged 5 commits intodeephaven:mainfrom
wusteven815:fix-frozen-sort
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1749 +/- ##
==========================================
+ Coverage 46.03% 46.12% +0.09%
==========================================
Files 621 627 +6
Lines 37455 37633 +178
Branches 9413 9474 +61
==========================================
+ Hits 17244 17360 +116
- Misses 20157 20218 +61
- Partials 54 55 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
Yeah, I would not sort the frozen columns |
mofojed
requested changes
Feb 5, 2024
mofojed
approved these changes
Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.