feat: toggle empty/null rendering#1778
Merged
wusteven815 merged 2 commits intodeephaven:mainfrom Feb 14, 2024
wusteven815:feat-1646-string-formatting
Merged
feat: toggle empty/null rendering#1778wusteven815 merged 2 commits intodeephaven:mainfrom wusteven815:feat-1646-string-formatting
wusteven815 merged 2 commits intodeephaven:mainfrom
wusteven815:feat-1646-string-formatting
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1778 +/- ##
==========================================
- Coverage 46.10% 46.05% -0.05%
==========================================
Files 627 628 +1
Lines 37622 37812 +190
Branches 9470 9526 +56
==========================================
+ Hits 17345 17416 +71
- Misses 20222 20342 +120
+ Partials 55 54 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
approved these changes
Feb 14, 2024
Member
mofojed
left a comment
There was a problem hiding this comment.
Looks good to me. I also tested to make sure that the props were read correctly when specified in deephaven.prop. By default the file is in ~/.config/deephaven/deephaven.prop, and I specified the showEmptyStrings and showNullStrings props by adding the following:
showEmptyStrings=true
showNullStrings=true
client.configuration.list=java.version,deephaven.version,barrage.version,showEmptyStrings,showNullStrings
User was still able to override the setting, which is expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IrisGridTableModelTemplateto check for if the setting is enabled