Skip to content

feat: Test Utils - Generate exhaustive boolean combinations and MockProxy spread#1811

Merged
bmingles merged 3 commits intodeephaven:mainfrom
bmingles:1809-boolean-util
Feb 16, 2024
Merged

feat: Test Utils - Generate exhaustive boolean combinations and MockProxy spread#1811
bmingles merged 3 commits intodeephaven:mainfrom
bmingles:1809-boolean-util

Conversation

@bmingles
Copy link
Copy Markdown
Contributor

@bmingles bmingles commented Feb 15, 2024

New test util features

  • Generate exhaustive boolean combinations
  • Fixed some type errors in usePickerWithSelectedValues.test.ts (also updated it to use the new boolean test util)
  • Added spread support to MockProxy to avoid empty objects when making copies
  • Fixed a console error that was happening due to null icons passed to FontAwesomeIcon component in tests

resolves #1809

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36bc251) 46.06% compared to head (acf544a) 46.11%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1811      +/-   ##
==========================================
+ Coverage   46.06%   46.11%   +0.04%     
==========================================
  Files         627      628       +1     
  Lines       37792    37822      +30     
  Branches     9522     9529       +7     
==========================================
+ Hits        17410    17440      +30     
  Misses      20328    20328              
  Partials       54       54              
Flag Coverage Δ
unit 46.11% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmingles bmingles requested a review from mofojed February 15, 2024 22:13
@bmingles bmingles merged commit 0a2f054 into deephaven:main Feb 16, 2024
@bmingles bmingles deleted the 1809-boolean-util branch February 16, 2024 22:45
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestUtils - Generate exhaustive boolean combinations

2 participants