feat: Test Utils - Generate exhaustive boolean combinations and MockProxy spread#1811
Merged
bmingles merged 3 commits intodeephaven:mainfrom Feb 16, 2024
Merged
feat: Test Utils - Generate exhaustive boolean combinations and MockProxy spread#1811bmingles merged 3 commits intodeephaven:mainfrom
bmingles merged 3 commits intodeephaven:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1811 +/- ##
==========================================
+ Coverage 46.06% 46.11% +0.04%
==========================================
Files 627 628 +1
Lines 37792 37822 +30
Branches 9522 9529 +7
==========================================
+ Hits 17410 17440 +30
Misses 20328 20328
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
approved these changes
Feb 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New test util features
usePickerWithSelectedValues.test.ts(also updated it to use the new boolean test util)nullicons passed to FontAwesomeIcon component in testsresolves #1809