fix: spectrum textfield validation icon position with set content-box#1825
Merged
fix: spectrum textfield validation icon position with set content-box#1825
Conversation
Moves a DHE fix to DHC. BREAKING CHANGE: the duplicate `spectrum-Textfield-validationIcon` css in DHE should be removed
Contributor
Author
|
feels like a bit of an abuse of breaking change, but not sure how else to flag that the DHE code can be removed when this is merged to DHE. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1825 +/- ##
=======================================
Coverage 46.11% 46.11%
=======================================
Files 628 628
Lines 37822 37822
Branches 9529 9529
=======================================
Hits 17440 17440
Misses 20328 20328
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bmingles
requested changes
Feb 22, 2024
Contributor
bmingles
left a comment
bmingles
left a comment
There was a problem hiding this comment.
Looks like e2e tests need to be updated
Contributor
Author
|
Flaky test failure, re-ran and it passed. |
bmingles
approved these changes
Feb 23, 2024
Contributor
bmingles
left a comment
bmingles
left a comment
There was a problem hiding this comment.
LGTM. Verified that the icon is positioned correctly in the styleguide y setting validationState="invalid"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves a DHE fix to DHC.
fixes text field spectrum validation icon position:
BREAKING CHANGE: the duplicate
spectrum-Textfield-validationIconcss in DHE should be removed