feat: Plugin loader should prioritize new plugin format, when available#1846
Merged
vbabich merged 2 commits intodeephaven:mainfrom Feb 29, 2024
Merged
feat: Plugin loader should prioritize new plugin format, when available#1846vbabich merged 2 commits intodeephaven:mainfrom
vbabich merged 2 commits intodeephaven:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1846 +/- ##
==========================================
+ Coverage 46.00% 46.03% +0.03%
==========================================
Files 635 635
Lines 37913 37931 +18
Branches 9553 9561 +8
==========================================
+ Hits 17441 17461 +20
+ Misses 20418 20416 -2
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
approved these changes
Feb 29, 2024
mattrunyon
approved these changes
Feb 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should be able to use both new and legacy plugin format in the same module, and plugin loader should prioritize the new format.