feat: new chart error panel#1850
Merged
mofojed merged 10 commits intodeephaven:mainfrom Apr 5, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1850 +/- ##
==========================================
- Coverage 46.26% 46.24% -0.03%
==========================================
Files 646 647 +1
Lines 38252 38269 +17
Branches 9673 9681 +8
==========================================
Hits 17697 17697
- Misses 20502 20519 +17
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ethanalvizo
commented
Mar 5, 2024
mofojed
requested changes
Mar 7, 2024
Member
mofojed
left a comment
There was a problem hiding this comment.
This has strange behaviour when running the snippet from #1520 (comment)
- Plot appears with message "Disable downsampling to retrieve all items" and a "Continue" button.
- I click Continue, then nothing appears in the plot.
I would assume that clicking Continue in that case with that message would mean the plot would try to load, loading spinner etc. but that doesn't appear to be the case. Why aren't we trying to load it?
Contributor
Author
mofojed
requested changes
Mar 27, 2024
mofojed
previously approved these changes
Mar 27, 2024
mofojed
approved these changes
Apr 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #1520