feat: Re-export Spectrum components + prop types#1880
Merged
bmingles merged 2 commits intodeephaven:mainfrom Mar 19, 2024
Merged
feat: Re-export Spectrum components + prop types#1880bmingles merged 2 commits intodeephaven:mainfrom
bmingles merged 2 commits intodeephaven:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1880 +/- ##
=======================================
Coverage 46.14% 46.14%
=======================================
Files 636 636
Lines 38072 38072
Branches 9628 9628
=======================================
Hits 17570 17570
Misses 20449 20449
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dsmmcken
approved these changes
Mar 19, 2024
Contributor
dsmmcken
left a comment
dsmmcken
left a comment
There was a problem hiding this comment.
I was going to complain about exposing some of them like logic button because it's not one we would ever use. However, that said exposing to dh.ui is fine and we want it wrapped. So carry on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-export most of the React Spectrum components listed in the docs. This excludes
resolves #1852