chore: Delete ValidateLabelInput#1887
Merged
vbabich merged 4 commits intodeephaven:mainfrom Mar 21, 2024
Merged
Conversation
vbabich
commented
Mar 20, 2024
Collaborator
Author
vbabich
left a comment
vbabich
left a comment
There was a problem hiding this comment.
Should I mark this as a breaking change?
auto-merge was automatically disabled
March 20, 2024 21:44
Pull request was converted to draft
vbabich
force-pushed
the
update-validate-label-input
branch
from
771f987 to
02f6ae2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1887 +/- ##
==========================================
- Coverage 46.14% 46.12% -0.03%
==========================================
Files 636 635 -1
Lines 38072 38047 -25
Branches 9628 9617 -11
==========================================
- Hits 17570 17549 -21
+ Misses 20449 20445 -4
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Yes. |
dsmmcken
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: ValidateLabelInput is no longer included in the
@deephaven/componentspackage.