Skip to content

fix: Invalid migration of legacy partitions#1892

Merged
mofojed merged 1 commit intodeephaven:mainfrom
mofojed:fix-partitions-migration
Mar 27, 2024
Merged

fix: Invalid migration of legacy partitions#1892
mofojed merged 1 commit intodeephaven:mainfrom
mofojed:fix-partitions-migration

Conversation

@mofojed
Copy link
Copy Markdown
Member

@mofojed mofojed commented Mar 22, 2024

  • We didn't check if the partition was null before adding it to an array
  • Was setting a partition of [null] for all migrated tables
  • Fix up unit tests to actually check the results instead of just checking against the object passed in

- We didn't check if the partition was `null` before adding it to an array
- Was setting a partition of `[null]` for all migrated tables
- Fix up unit tests
@mofojed mofojed requested a review from vbabich March 22, 2024 16:10
@mofojed mofojed self-assigned this Mar 22, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.11%. Comparing base (29353c2) to head (2a3ebd2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1892      +/-   ##
==========================================
- Coverage   46.12%   46.11%   -0.02%     
==========================================
  Files         635      637       +2     
  Lines       38047    38056       +9     
  Branches     9617     9619       +2     
==========================================
  Hits        17549    17549              
- Misses      20445    20454       +9     
  Partials       53       53              
Flag Coverage Δ
unit 46.11% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed merged commit 96298f6 into deephaven:main Mar 27, 2024
@mofojed mofojed deleted the fix-partitions-migration branch March 27, 2024 17:34
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants