fix: allow plotly plots to shrink inside ui.flex/grid layouts#1946
Merged
fix: allow plotly plots to shrink inside ui.flex/grid layouts#1946
Conversation
- set responsive config to true which allows plots to properly grow and shrink - removed unecessary useResizeHandler (which only watches window), as we have our own observer
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1946 +/- ##
==========================================
- Coverage 46.18% 46.18% -0.01%
==========================================
Files 647 647
Lines 38340 38343 +3
Branches 9704 9706 +2
==========================================
Hits 17709 17709
- Misses 20578 20581 +3
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with the following script, and resizing golden-layout panels both vertically and horizontally and resizing browser window horizontally and vertically.