fix: Fixed ListView props#1986
Merged
bmingles merged 1 commit intodeephaven:mainfrom May 3, 2024
Merged
Conversation
bmingles
force-pushed
the
1985-list-view-change-handlers
branch
from
9aa0a35 to
a779810
Compare
bmingles
force-pushed
the
1985-list-view-change-handlers
branch
from
a779810 to
ebb1e2c
Compare
mofojed
approved these changes
May 3, 2024
Comment on lines
+76
to
+78
| selectedKeys={ | ||
| selectedKeys as ListViewWrapperProps<unknown>['selectedKeys'] | ||
| } |
Member
There was a problem hiding this comment.
Do we have a ticket or PR with Spectrum to include boolean in their keys? Kind of annoying we need to do this casting.
Contributor
Author
There was a problem hiding this comment.
We have a related one adobe/react-spectrum#6103 but not one for the types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wired up ListView props I missed on refactor.