fix: PouchStorageTable using incorrect $ne operator#2011
Merged
AkshatJawne merged 6 commits intodeephaven:mainfrom May 15, 2024
Merged
fix: PouchStorageTable using incorrect $ne operator#2011AkshatJawne merged 6 commits intodeephaven:mainfrom
AkshatJawne merged 6 commits intodeephaven:mainfrom
Conversation
Contributor
|
Re-ran your failed e2e and it passed. I think it was just webkit timeouts, we are working to fix that. |
bmingles
reviewed
May 14, 2024
bmingles
reviewed
May 14, 2024
mofojed
requested changes
May 14, 2024
bmingles
reviewed
May 14, 2024
Contributor
Author
|
@bmingles Have added the test cases for the regex types, however,a fter adding them I kept getting this error: Figured that there was an issue with our old regex (but may have never been picked up given the any type), so I modified it. Let me know what you think about this |
bmingles
reviewed
May 15, 2024
mofojed
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves #1505
Changes:
PouchFiltertype to use $ne instead of $neq$regexprop to be able to acceptRegExpandstring, rather than just string by defaultSteps Moving Forward:
Update: Apparently, there are some issues with PouchDB and jest tests, since it has not been updated to an ES6 module. (https://stackoverflow.com/questions/64905287/import-error-when-running-jest-tests-that-use-the-pouchdb-asyncstorage-adapter). Could create a
babel.config.js, but not sure if we want to do that just for a function that is never used beyond an internal scope. Thus, going to omit unit tests for now.