Skip to content

feat: re-export Spectrum ButtonGroup#2028

Merged
bmingles merged 12 commits intodeephaven:mainfrom
bmingles:2016-button-group-reexport
May 24, 2024
Merged

feat: re-export Spectrum ButtonGroup#2028
bmingles merged 12 commits intodeephaven:mainfrom
bmingles:2016-button-group-reexport

Conversation

@bmingles
Copy link
Copy Markdown
Contributor

  • Added Spectrum ButtonGroup support to DH Button
  • Re-exported Spectrum ButtonGroup

resolves #2016

@bmingles bmingles requested a review from mofojed May 23, 2024 22:36
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed we have the same snapshots taken a few times for the socketed buttons section - is that necessary? Seems like we should only be taking one snapshot of the section to verify everything?

In any case, not related to this change necessarily. Can be a follow up if needed to clean up.

@bmingles bmingles merged commit 3115dd1 into deephaven:main May 24, 2024
@bmingles bmingles deleted the 2016-button-group-reexport branch May 24, 2024 14:20
@github-actions github-actions Bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-export Spectrum ButtonGroup and make dh Button compatible

2 participants