fix: Remove TreeTableViewportUpdater, TableViewportUpdater, and StorageTableViewportUpdater#2057
Merged
AkshatJawne merged 2 commits intodeephaven:mainfrom Jun 7, 2024
Conversation
Collaborator
|
These are actually consumed in DHE, so this should be marked as breaking. There should be info on this in the Also, |
mofojed
requested changes
Jun 6, 2024
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
May as well get rid of StorageTableViewportUpdater as well in this PR, add it to the BREAKING CHANGE list
AkshatJawne
changed the title
mofojed
approved these changes
Jun 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1930
BREAKING CHANGE: Removed
TreeTableViewportUpdater,TableViewportUpdater, andStorageTableViewportUpdater. If wanting to continue using them, copy the deleted files from this PR.