feat: ComboBox - @deephaven/jsapi-components#2077
Merged
bmingles merged 7 commits intodeephaven:mainfrom Jul 3, 2024
Merged
Conversation
fa5b8ea to
0a0d7bc
Compare
f2b00e1 to
3465f98
Compare
3465f98 to
c0407f6
Compare
bmingles
commented
Jun 27, 2024
| // Copy table so we can apply filters without affecting the original table. | ||
| // (Note that this call is not actually applying any filters. Filter will be | ||
| // applied in `useSearchableViewportData`.) | ||
| const { data: tableCopy } = usePromiseFactory( |
Contributor
Author
There was a problem hiding this comment.
@mofojed for reference, I think this is where we could apply addition filters as part of @AkshatJawne partition table work
Contributor
Author
There was a problem hiding this comment.
I guess it might make sense to just add it to this PR, but I'm fine either way
mofojed
approved these changes
Jul 3, 2024
mofojed
requested changes
Jul 3, 2024
Member
mofojed
left a comment
There was a problem hiding this comment.
Only thing that needs updating is the PR description
Show passing in a ui.item_table_data_source instead of passing in props for key_column directly on combo_box.
mofojed
approved these changes
Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jsapi support for ComboBox. Includes some splitting out of existing Picker logic to make code re-usable.
Should be testable with plugins PR deephaven/deephaven-plugins#588
I have also deployed an alpha 0.83.1-alpha-combobox.8 if you need it, although should only matter for types I think.
There is a known issue with inconsistent open as you type for table data sources.
#2115
resolves #2074