fix: DH-17199: Filter by value in the tree table context menu always shows null #2078
Merged
vbabich merged 1 commit intodeephaven:mainfrom Jun 13, 2024
Merged
fix: DH-17199: Filter by value in the tree table context menu always shows null #2078vbabich merged 1 commit intodeephaven:mainfrom
vbabich merged 1 commit intodeephaven:mainfrom
Conversation
…TreeTableModel snapshot method
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2078 +/- ##
==========================================
- Coverage 46.60% 46.60% -0.01%
==========================================
Files 677 677
Lines 38564 38565 +1
Branches 9769 9769
==========================================
Hits 17974 17974
- Misses 20538 20539 +1
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
approved these changes
Jun 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide an initializer for the optional
formatValueargument inIrisGridTreeTableModelsnapshotmethod.Remove the conditional that caused the
resultRowto be an empty array when theformatValueargument isn't provided.