fix: DH-17292 Handle disconnect from GridWidgetPlugin#2086
fix: DH-17292 Handle disconnect from GridWidgetPlugin#2086mofojed merged 4 commits intodeephaven:mainfrom
Conversation
mofojed
commented
Jun 20, 2024
- When the model is disconnected, we should just display an error. There's no option to reconnect, as the widget schema could change entirely
- By unloading the IrisGrid component, it's no longer throwing an error by trying to access table methods after a table.close()
- Fixes DH-17292 from Enterprise
- Tested using the steps in the description
- When the model is disconnected, we should just display an error. There's no option to reconnect, as the widget schema could change entirely - By unloading the IrisGrid component, it's no longer throwing an error by trying to access table methods after a table.close() - Fixes DH-17292 from Enterprise - Tested using the steps in the description
mattrunyon
left a comment
There was a problem hiding this comment.
Does this need to be fixed with ChartWidgetPlugin too? I'd guess yes since it has basically the same setup as GridWidgetPlugin
|
And possibly |
|
I checked w/ It does show a stale chart until the new widget is loaded though. That could be handled in a separate ticket |
|
@mattrunyon Figure (and Table/Pandas Table) and everything in deephaven.ui should be displaying the error panel with https://github.com/deephaven-ent/iris/pull/1822 and the latest v0.15 deephaven.ui. So not too worried if there's a stale chart shown behind that error. |
- Minimize code duplication - Added unit tests
|
Having a hard time debugging the Pandas thing because of a Pandas Enterprise issue: https://deephaven.atlassian.net/issues/DH-17081 |
|
Now that we no longer show the widget after a disconnect/error (deephaven/deephaven-plugins#585) this PR is no longer relevant and will be closed. |
|
Actually I realized there's some refactoring here ( |
- Add some more unit tests for transitions of states