fix: Ref was not being passed through for Picker#2122
Merged
mofojed merged 3 commits intodeephaven:mainfrom Jul 3, 2024
Merged
fix: Ref was not being passed through for Picker#2122mofojed merged 3 commits intodeephaven:mainfrom
mofojed merged 3 commits intodeephaven:mainfrom
Conversation
- Pass through ref to SpectrumPicker correctly
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2122 +/- ##
=======================================
Coverage 46.58% 46.59%
=======================================
Files 681 682 +1
Lines 38431 38441 +10
Branches 9762 9701 -61
=======================================
+ Hits 17905 17912 +7
+ Misses 20516 20477 -39
- Partials 10 52 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bmingles
reviewed
Jul 3, 2024
bmingles
requested changes
Jul 3, 2024
Contributor
bmingles
left a comment
bmingles
left a comment
There was a problem hiding this comment.
Left a comment regarding the scroll ref
Member
Author
|
I tested this with DHE, looks to be working correctly. |
bmingles
reviewed
Jul 3, 2024
bmingles
reviewed
Jul 3, 2024
bmingles
previously approved these changes
Jul 3, 2024
Contributor
bmingles
left a comment
bmingles
left a comment
There was a problem hiding this comment.
Looks good. Left question about additional test case but I wouldn't hold up PR for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useMultiRefhook for handling multiple refs being passed in