fix: ChartBuilderPlugin fixes for charts built from PPQs in Enterprise#2167
Merged
mofojed merged 9 commits intodeephaven:mainfrom Sep 11, 2024
Merged
Conversation
- Should be opening up correctly now...
- Wasn't working for charts created from Parameterized Queries
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2167 +/- ##
==========================================
+ Coverage 46.75% 46.78% +0.02%
==========================================
Files 694 694
Lines 38639 38627 -12
Branches 9785 9659 -126
==========================================
+ Hits 18065 18070 +5
- Misses 20521 20546 +25
+ Partials 53 11 -42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mattrunyon
requested changes
Jul 23, 2024
Collaborator
mattrunyon
left a comment
mattrunyon
left a comment
There was a problem hiding this comment.
Is there a DHE ticket associated with this?
| (props: WidgetPanelProps<DhType.plot.Figure>, ref: React.Ref<ChartPanel>) => { | ||
| const dh = useApi(); | ||
| const fetchObject = useObjectFetcher(); | ||
| const deferredApi = useContext(DeferredApiContext); |
Collaborator
There was a problem hiding this comment.
This makes me wonder if we should still have useApi. Could useApi cause unknown bugs in DHE because we don't have the same complexity in DHC? I guess either way we would have to be cognizant of when to pass the metadata
Also, why not useDeferredApi(metadata) here?
- Use useDeferredApi instead of fetching from context directly - Allow null to be passed in for descriptor in useDeferredApi and throw an error accordingly
- Don't return an error from makeModel until the API has loaded or an error has occurred - Allow ChartPanel to reload if makeModel has updated even if it hasn't loaded a model yet
mattrunyon
requested changes
Sep 10, 2024
mattrunyon
approved these changes
Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppDashboards- the descriptor gets sanitized within the objectFetcher itselfpanelFetchto get the underlying objectParameterizedQueryon Enterprise, we only have the result of theParameterizedQueryrun in theParameterizedQueryPanelParameterizedQuerysupport, we should complete DH-15760 (which would be breaking an internal API)