fix: DH-17454: Combine modal classes instead of replacing#2173
Merged
vbabich merged 2 commits intodeephaven:mainfrom Jul 26, 2024
Merged
fix: DH-17454: Combine modal classes instead of replacing#2173vbabich merged 2 commits intodeephaven:mainfrom
vbabich merged 2 commits intodeephaven:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2173 +/- ##
==========================================
- Coverage 46.67% 46.66% -0.01%
==========================================
Files 692 692
Lines 38628 38625 -3
Branches 9631 9812 +181
==========================================
- Hits 18028 18025 -3
Misses 20589 20589
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
For completion you probably wanna update ModalHeader to be the same format. |
Collaborator
Author
Ok, I saw ModalHeader already combines classes, just uses a template literal instead of separate arguments. I'll update it too. |
dsmmcken
approved these changes
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.