fix: Errors thrown during a grid update are not caught#2188
Merged
mattrunyon merged 1 commit intodeephaven:mainfrom Aug 14, 2024
Merged
fix: Errors thrown during a grid update are not caught#2188mattrunyon merged 1 commit intodeephaven:mainfrom
mattrunyon merged 1 commit intodeephaven:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2188 +/- ##
==========================================
- Coverage 46.67% 46.67% -0.01%
==========================================
Files 692 692
Lines 38630 38635 +5
Branches 9630 9631 +1
==========================================
+ Hits 18029 18031 +2
- Misses 20590 20593 +3
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
approved these changes
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors thrown during a
requestAnimationFrameare not caught because they're thrown from a separate stack than the component. This means any render method that throws after the first grid render won't actually be caught and the grid will potentially draw incorrectly.