fix: Layout shifts when opening and closing panels from a fresh state#2241
Merged
mattrunyon merged 2 commits intodeephaven:mainfrom Oct 1, 2024
Merged
fix: Layout shifts when opening and closing panels from a fresh state#2241mattrunyon merged 2 commits intodeephaven:mainfrom
mattrunyon merged 2 commits intodeephaven:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2241 +/- ##
==========================================
- Coverage 46.42% 46.42% -0.01%
==========================================
Files 698 698
Lines 38751 38750 -1
Branches 9860 9885 +25
==========================================
- Hits 17991 17990 -1
+ Misses 20749 20706 -43
- Partials 11 54 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bmingles
approved these changes
Oct 1, 2024
Contributor
bmingles
left a comment
bmingles
left a comment
There was a problem hiding this comment.
Changes look good. I confirmed the layout no longer shifts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1268
This mostly occurs when you have a relatively fresh state. There's a video in the ticket, but if you have just 2 rows then this is frequently triggered. Using incognito mode should give you a fresh state which is affected by this bug.
This fixes both the vertical shift when you open a new panel type (open a notebook from a fresh state or open a table from a fresh layout state) and when you close the last panel in a stack (like in the ticket)