fix: No context menu item for paste in an input table#2341
Conversation
This works now but need to revisit how and why
…paste-in-an-input-table
…paste-in-an-input-table
is there any documentation on this?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2341 +/- ##
==========================================
+ Coverage 46.70% 46.76% +0.06%
==========================================
Files 704 710 +6
Lines 39044 39107 +63
Branches 9757 9958 +201
==========================================
+ Hits 18234 18288 +54
+ Misses 20799 20765 -34
- Partials 11 54 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
left a comment
There was a problem hiding this comment.
Exceptions should still be thrown/caught, rather than mapping to null. Excellent work, great find confirming the old behaviour in Firefox as well!
mofojed
left a comment
There was a problem hiding this comment.
Great work! Just one minor thing that can be simplified.
See how using exceptions instead of returning null gives you better flexibility about how you handle exceptional cases.
clipboard-readpermission (e.g. Chrome), clicking paste results in the same behaviour as pressing the keyboard shortcut, provided the user has accepted the request for permissionclipboard-readpermission (e.g. Firefox and Safari), a modal is shown to explain the reason and to suggest using the keyboard shortcut insteadAdditional related issues fixed
instead of which we were expecting before. Was able to reproduce former behaviour on an older build of Firefox (91.0), meaning this discrepancy is likely caused by an update to Firefox (unsure when exactly)